Update and add missing descriptions to ETCD module#10592
Merged
sayden merged 3 commits intoelastic:masterfrom Feb 6, 2019
Merged
Update and add missing descriptions to ETCD module#10592sayden merged 3 commits intoelastic:masterfrom
sayden merged 3 commits intoelastic:masterfrom
Conversation
sayden
added
enhancement
Metricbeat
ruflin
approved these changes
Feb 6, 2019
Contributor
|
@sayden For your questions around polishing: I think the answer is yes. Should we open a separate issue to discuss these improvements? |
Contributor
Author
|
Yes, let's merge this here and open a new issue for discussion. |
sayden
added a commit
to sayden/beats
that referenced
this pull request
Feb 6, 2019
(cherry picked from commit da2c258) # Conflicts: # metricbeat/docs/fields.asciidoc # metricbeat/module/etcd/fields.go
sayden
added
v6.7.0
and removed
needs_backport
urso
added
needs_backport
sayden
added a commit
that referenced
this pull request
Feb 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10239 and adds some missing descriptions.
I'm not sure if this module needs a bit of polishing. On one side we are using fields like
average,currentorstandardDeviationthat maybe should be omitted leaving onlycurrent. On the other side we have fields likeetcd.self.recv.appendrequest.countthat maybe should be calledetcd.self.received.append_requestsor aetcd.self.recv.pkgratethat maybe should beetcd.self.received.packages_rate.per_secoretcd.store.compareanddelete.fail(etcd.store.compare_and_delete.fail)By the way, I also saw that
data.jsonfiles are not complete because the module uses a compose configuration without clustering. I'm not sure if this can just be updated by using a manually created cluster so that it shows all possible fields or it should be created in CI (or matched in the CI). For example, in theleadermetricset we have this data.json file but we might have this:{ "@timestamp": "2017-10-12T08:05:34.853Z", "agent": { "hostname": "host.example.com", "name": "host.example.com" }, "etcd": { "leader": { "followers": { "5a22bdba1efc5b4a": { "latency": { "average": 0.0024145817307692323, "current": 0.001494, "maximum": 0.061351, "minimum": 0, "standardDeviation": 0.0029017970782575734 }, "counts": { "success": 1248, "fail": 0 } }, "639ec377a30542cf": { "latency": { "average": 0.0026389089456869013, "current": 0.001241, "maximum": 0.233578, "minimum": 0, "standardDeviation": 0.00695758066274549 }, "counts": { "success": 1252, "fail": 0 } } }, "leader": "d3cf079af51fa9a8" } }, "event": { "dataset": "etcd.leader", "duration": 115000, "module": "etcd" }, "metricset": { "name": "leader" }, "service": { "address": "127.0.0.1:2379", "type": "etcd" } }